-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not freeze process.env in dev #12585
Conversation
🦋 Changeset detectedLatest commit: ac0e2e8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #12585 will not alter performanceComparing Summary
|
/snapshot astroenv-dev |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a nit around the template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until we have a solution for #12618
@bluwy I think I have a fix for that issue, see |
…into fix/astro-env-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I can help you to test it with a preview release
Co-authored-by: Emanuele Stoppa <[email protected]>
/snapshot astroenv-dev |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
With the latest fix, I think it would fix the regression for now. But it doesn't fix the case where |
I'll test it on monday |
@bluwy I just tested manually in the basics example woth |
Changes
Testing
Docs
N/A